On Mon, Oct 5, 2020 at 2:41 PM Andrea Bolognani <abologna@xxxxxxxxxx> wrote:
>
> To keep things maintainable, we want to have architecture handling
> all in one spot instead of sprinkling %ifarch conditionals all over
> the place.
>
> Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
> ---
> libvirt.spec.in | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 65df7dc79f..2401404008 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -94,6 +94,7 @@
> %define with_libssh2 0
> %define with_wireshark 0
> %define with_libssh 0
> +%define with_dmidecode 0
>
> # Finally set the OS / architecture specific special cases
>
> @@ -183,6 +184,10 @@
> %endif
> %endif
>
> +%ifarch %{ix86} x86_64
> + %define with_dmidecode 0%{!?_without_dmidecode:1}
> +%endif
> +
> # Force QEMU to run as non-root
> %define qemu_user qemu
> %define qemu_group qemu
> @@ -434,7 +439,7 @@ Requires: iproute-tc
> %endif
>
> Requires: polkit >= 0.112
> -%ifarch %{ix86} x86_64
> +%if %{with_dmidecode}
> # For virConnectGetSysinfo
> Requires: dmidecode
> %endif
> --
> 2.26.2
>
Reviewed-by: Neal Gompa <ngompa13@xxxxxxxxx>
--
真実はいつも一つ！/ Always, there's only one truth!
