On Mon, Jun 22, 2020 at 12:14:56 +0100, Daniel Berrange wrote: > On Fri, Jun 19, 2020 at 12:18:23PM +0200, Peter Krempa wrote: > > On Fri, Jun 19, 2020 at 10:32:47 +0100, Daniel Berrange wrote: > > > The term is redundant or easily substituted with 'prohibit'. > > > > > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > > > --- [...] > > > diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 > > > index d3538d59f8..4ebc25302c 100644 > > > --- a/m4/virt-compile-warnings.m4 > > > +++ b/m4/virt-compile-warnings.m4 > > > @@ -123,7 +123,7 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ > > > # Get all possible GCC warnings > > > gl_MANYWARN_ALL_GCC([maybewarn]) > > > > > > - # Remove the ones we don't want, blacklisted earlier > > > + # Remove the ones we don't want > > > gl_MANYWARN_COMPLEMENT([wantwarn], [$maybewarn], [$dontwarn]) > > > > IMO this change doesn't make sense in the light of the meson rewrite. > > Sure, this will go away when meson switch arrives, but we've still not > got a clear ETA for that, so we shouldn't reject changes to the existing > build system in the meantime. Main reason is to minimize conflicts with Pavel's effort. This hunk is here since 2012, so waiting even for amonth doesn't seem to be that much of a problem.
