On Fri, Jun 19, 2020 at 12:18:23PM +0200, Peter Krempa wrote: > On Fri, Jun 19, 2020 at 10:32:47 +0100, Daniel Berrange wrote: > > The term is redundant or easily substituted with 'prohibit'. > > > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > > --- > > build-aux/syntax-check.mk | 2 +- > > m4/virt-compile-warnings.m4 | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk > > index d47a92b530..2e49b5172e 100644 > > --- a/build-aux/syntax-check.mk > > +++ b/build-aux/syntax-check.mk > > @@ -1155,7 +1155,7 @@ sc_prohibit_class: > > # exists some filesystems will only ever return DT_UNKNOWN. > > # This field should only be used by code which is exclusively > > # run platforms supporting "d_type" and must expect DT_UNKNOWN. > > -# We blacklist it to discourage accidental usage which has > > +# We prohibit it to discourage accidental usage which has > > This may or may not make sence depending on how syntax check is ported > to meson. You can use my R-b for this hunk if this survives the rewrite. I'd expect this file to be unchanged with meson. This is why we changed it to be independant of the current makefile infra when getting rid of gnulib. > > # happened many times. Add an exclude rule if it is genuinely > > # needed and the above restrictions are acceptable. > > sc_prohibit_dirent_d_type: > > diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 > > index d3538d59f8..4ebc25302c 100644 > > --- a/m4/virt-compile-warnings.m4 > > +++ b/m4/virt-compile-warnings.m4 > > @@ -123,7 +123,7 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ > > # Get all possible GCC warnings > > gl_MANYWARN_ALL_GCC([maybewarn]) > > > > - # Remove the ones we don't want, blacklisted earlier > > + # Remove the ones we don't want > > gl_MANYWARN_COMPLEMENT([wantwarn], [$maybewarn], [$dontwarn]) > > IMO this change doesn't make sense in the light of the meson rewrite. Sure, this will go away when meson switch arrives, but we've still not got a clear ETA for that, so we shouldn't reject changes to the existing build system in the meantime. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
