Re: [libvirt PATCH] ci: Reduce number of stages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 10, 2020 at 13:33:01 +0200, Andrea Bolognani wrote:

[...]

> Building artifacts in a separate pipeline stage also doesn't have any
> advantages, and only delays further stages by a couple of minutes.
> The only job that really makes sense in its own stage is the DCO
> check, because it's extremely fast (less than 1 minute) and, if that
> fails, we can avoid kicking off all other jobs.

On the contrary I think that the DCO check should be made after builds
as that usually forces users to add a sign-off just to bypass that check
if they want to sanity check their series.

Since the lack of a sign off can be effectively used as a mark for an
patch that is not ready to be pushed, but a build-check is still needed.
This adds a pointless hurdle in using the CI and also removes one of the
meaningful uses to have a sign off checker.





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux