On Tue, May 05, 2020 at 04:33:48PM +0200, Andrea Bolognani wrote: > On Tue, 2020-05-05 at 14:49 +0100, Daniel P. Berrangé wrote: > > On Tue, May 05, 2020 at 03:31:55PM +0200, Andrea Bolognani wrote: > > > Please at least update the inventory so > > > that it accurately records which targets are supposed to be able to > > > build the new project. > > > > That's only required for VM builds, and would use of the "all" > > wildcard when building VMs, so I'm not wanting to do that, as I > > won't have tested anything related to VMs. > > It also serves as documentation for our expectations when it comes to > which project can be built on which platform, and was intended to > prevent the use of > > ./lctiool $action $target $project > > when $target is known not to support $project, even though we didn't > enfore that for 'update' and 'build' in order to make > > ./lcitool $action all all > > work smoothly, and 'dockerfile' lost the check in one of your > recent patches... IIUC, "lcitool build libvirt-fedora-32 all" will try to build all projects in the host's inventory. So if we add libvirt-rust, to the host inventory we need to full the full VM setup for the project, otherwise we'll break this build. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
