On Tue, 2020-05-05 at 12:48 +0100, Daniel P. Berrangé wrote:
> + php-imagick:
> + default: php-imagick
> + FreeBSD: php74-pecl-imagick
> + Fedora: php-pecl-imagick
> + CentOS: php-pecl-imagick
> + CentOS8:
This could be
php-imagick:
deb: php-imagick
rpm: php-pecl-imagick
pkg: php74-pecl-imagick
CentOS8:
This patch is also missing the part where the libvirt-php project is
added to the 'projects' fact for all targets that actually support
building it, which would be all of them but CentOS 8 in this case I
guess?
We're also missing build steps for the project. I understand that,
as we move stuff off CentOS CI and into GitLab CI containers become
more important than VMs, but I think keeping 'lcitool build' working
is still important, if nothing else as a development tool. It
certainly makes my life easier as a reviewer... Not to mention it is
the only way we can currently validate FreeBSD changes.
--
Andrea Bolognani / Red Hat / Virtualization
