OK, Michal. I will do this job later, thanks for your advice.
> On 4/26/20 1:56 PM, yubihong wrote:
> > There are some code format problems in src/libvirt-domain.c. This
> > patch fixes these problems.
> >
> >>From 55cd85345b2dc50f44c1e382563482d40142382b Mon Sep 17 00:00:00
> > 2001
> > From: yubihong <yubihong@xxxxxxxxxx>
> > Date: Fri, 24 Apr 2020 17:44:43 +0800
> > Subject: [PATCH] qemu: fix code format problem
> >
> > Signed-off-by:Yu Bihong <yubihong@xxxxxxxxxx>
> > ---
> > src/libvirt-domain.c | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index
> > a12809c..d659f1b
> > 100644
> > --- a/src/libvirt-domain.c
> > +++ b/src/libvirt-domain.c
> > @@ -8194,11 +8194,11 @@ virDomainAttachDevice(virDomainPtr domain,
> > const char *xml)
> > virCheckReadOnlyGoto(conn->flags, error);
> >
> > if (conn->driver->domainAttachDevice) {
> > - int ret;
> > - ret = conn->driver->domainAttachDevice(domain, xml);
> > - if (ret < 0)
> > - goto error;
> > - return ret;
> > + int ret;
> > + ret = conn->driver->domainAttachDevice(domain, xml);
> > + if (ret < 0)
> > + goto error;
> > + return ret;
> > }
> >
> > virReportUnsupportedError();
> > @@ -8299,9 +8299,9 @@ virDomainDetachDevice(virDomainPtr domain,
> const
> > char *xml)
> > if (conn->driver->domainDetachDevice) {
> > int ret;
> > ret = conn->driver->domainDetachDevice(domain, xml);
> > - if (ret < 0)
> > - goto error;
> > - return ret;
> > + if (ret < 0)
> > + goto error;
> > + return ret;
> > }
> >
> > virReportUnsupportedError();
> > --
> > 1.8.3.1
> >
>
> This patch doesn't apply cleanly. Can you please resend using git-send-email
> as our documentation suggest?
>
> https://libvirt.org/submitting-patches.html
>
> The idea looks good, but I guess there are more places in the file that are
> misaligned. Might be worth extending your patch and include them.
>
> Michal
