Re: [PATCH] qemu: fix code format problem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2020-04-26 at 11:56 +0000, yubihong wrote:
> There are some code format problems in src/libvirt-domain.c. This patch fixes
> these problems.

This patch does not apply:

  Applying: qemu: fix code format problem
  error: git diff header lacks filename information when removing 1 leading pathname component (line 6)
  Patch failed at 0001 qemu: fix code format problem
  hint: Use 'git am --show-current-patch' to see the failed patch
  When you have resolved this problem, run "git am --continue".
  If you prefer to skip this patch, run "git am --skip" instead.
  To restore the original branch and stop patching, run "git am --abort".

I think the issue is caused by the comments that you added at the
very top. If you want to add some information at the time of posting
that doesn't need to be retained in the git history, it should go...

> > From 55cd85345b2dc50f44c1e382563482d40142382b Mon Sep 17 00:00:00
> 2001
> From: yubihong <yubihong@xxxxxxxxxx>
> Date: Fri, 24 Apr 2020 17:44:43 +0800
> Subject: [PATCH] qemu: fix code format problem
> 
> Signed-off-by:Yu Bihong <yubihong@xxxxxxxxxx>
> ---

... right here.

>  src/libvirt-domain.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Please resend the patch in a form that can be applied. See

  https://libvirt.org/submitting-patches.html

for hints on how to achieve that.

While you're at it, please also fix your Signed-off-by so that it
looks like

  Signed-off-by: Yu Bihong <yubihong@xxxxxxxxxx>

(notice the additional whitespace) and configure your git client so
that authorship information (name and last name) match those in the
Signed-off-by.

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux