Re: [PATCH 5/8] domain: save/restore the state of dbus-daemon running

[Michal Privoznik <mprivozn@xxxxxxxxxx>]

On 1/14/20 2:46 PM, marcandre.lureau@xxxxxxxxxx wrote:
> From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
>
> This avoids trying to start a dbus-daemon when its already running.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> ---
>   src/qemu/qemu_domain.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index 7722a53c62..dda3cb781f 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -2916,6 +2916,9 @@ qemuDomainObjPrivateXMLFormat(virBufferPtr buf,
>                             virDomainChrTypeToString(priv->monConfig->type));
>       }
>   
> +    if (priv->dbusDaemonRunning)
> +        virBufferAddLit(buf, "<dbusDaemon/>\n");
> +
>       if (priv->namespaces) {
>           ssize_t ns = -1;
>   
> @@ -3697,6 +3700,8 @@ qemuDomainObjPrivateXMLParse(xmlXPathContextPtr ctxt,
>           goto error;
>       }
>   
> +    priv->dbusDaemonRunning = virXPathBoolean("boolean(./dbusDaemon)", ctxt) > 0;
> +
>       if ((node = virXPathNode("./namespaces", ctxt))) {
>           xmlNodePtr next;
>   

I'd push these a bit down - closer to PR daemon and slirp so that they 
are grouped together.

Michal