Re: [PATCH 6/8] qemu: prepare and stop the dbus daemon

Michal Privoznik <mprivozn@xxxxxxxxxx> · Thu, 20 Feb 2020 10:04:13 +0100

On 1/14/20 2:46 PM, marcandre.lureau@xxxxxxxxxx wrote:
From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>

Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
---
  src/qemu/qemu_process.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 4195042194..845a7caa55 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -58,6 +58,7 @@
  #include "qemu_extdevice.h"
  #include "qemu_firmware.h"
  #include "qemu_backup.h"
+#include "qemu_dbus.h"
  
  #include "cpu/cpu.h"
  #include "cpu/cpu_x86.h"
@@ -6457,6 +6458,9 @@ qemuProcessPrepareHost(virQEMUDriverPtr driver,
      qemuDomainObjPrivatePtr priv = vm->privateData;
      g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver);
  
+    if (qemuDBusPrepareHost(driver) < 0)
+        return -1;
+

Again, put this closer to qemuExtDevicesPrepareHost() so that it's close 
to each other.

      if (qemuPrepareNVRAM(cfg, vm) < 0)
          return -1;
  
@@ -7378,6 +7382,8 @@ void qemuProcessStop(virQEMUDriverPtr driver,
  
      qemuExtDevicesStop(driver, vm);
  
+    qemuDBusStop(driver, vm);
+
      vm->def->id = -1;
  
      /* Stop autodestroy in case guest is restarted */


Michal








