On Fri, Jan 10, 2020 at 03:41:14PM +0000, Daniel P. Berrangé wrote: > The GNULIB termios module ensures termios.h exists, but > this is not neccessary and libvirt doesn't use any of its > functionality on platforms where it is missing. It is > thus sufficient to conditonallyinclude termios.h > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > --- > configure.ac | 1 + > src/util/virfdstream.c | 4 +++- > src/util/virfile.c | 4 +++- > src/util/virutil.c | 1 - > tools/virsh.h | 1 - > tools/vsh.h | 4 +++- > 6 files changed, 10 insertions(+), 5 deletions(-) This makes the code guarded by HAVE_CFMAKERAW or by !WIN32 and the header by HAVE_TERMIOS_H which makes things more confusing. Should we take the opportunity to unify it? Pavel
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
