A continued effort to purge gnulib from the libvirt build system. The bulk of the win comes from implementing our own Winsock portability wrappers. The use of GSocket turned out to have many complications, making it hard for us to achieve the same level of functionality as we currently have. Thus we take a simpler wrapping approach that GNULIB does for Winsock too. NB this has only been compile tested so far. The sockets stuff definitely needs functional testing on Windows before I dare push it Daniel P. Berrangé (12): src: import gnulib's intprops.h header tests: always declare environ build: validate headers against local gnulib not git repo util: add detection of openpty function util: introduce compat wrappers for Winsock2 src: convert code to use new socket portability wrappers util: pull gnulib physmem impl into local code util: replace atomic ops impls with g_atomic_int* src: replace verify(expr) with G_STATIC_ASSERT(expr) src: add check for termios.h and conditionally include it src: replace gmtime_r/localtime_r/strftime with GDateTime bootstrap: remove 25 more gnulib modules bootstrap.conf | 50 -- build-aux/syntax-check.mk | 18 +- configure.ac | 5 + m4/virt-manywarnings.m4 | 339 ++++++++++++++ m4/virt-warnings.m4 | 115 +++++ src/conf/capabilities.c | 1 - src/conf/domain_conf.c | 11 +- src/conf/snapshot_conf.h | 2 +- src/conf/virdomaincheckpointobjlist.c | 8 +- src/esx/esx_network_driver.c | 2 +- src/esx/esx_storage_backend_iscsi.c | 2 +- src/esx/esx_storage_backend_vmfs.c | 2 +- src/hyperv/hyperv_driver.c | 2 +- src/internal.h | 1 - src/libvirt-domain.c | 2 +- src/libxl/libxl_domain.c | 12 +- src/libxl/libxl_driver.c | 2 +- src/libxl/xen_xm.c | 3 +- src/lxc/lxc_process.c | 4 +- src/nwfilter/nwfilter_dhcpsnoop.c | 10 +- src/nwfilter/nwfilter_ebiptables_driver.c | 2 +- src/nwfilter/nwfilter_learnipaddr.c | 2 +- src/qemu/qemu_blockjob.h | 4 +- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_command.c | 17 +- src/qemu/qemu_driver.c | 12 +- src/qemu/qemu_firmware.h | 2 +- src/qemu/qemu_migration_params.c | 2 +- src/qemu/qemu_process.c | 4 +- src/remote/remote_daemon_dispatch.c | 12 +- src/remote/remote_driver.c | 2 +- src/rpc/virnetsocket.c | 34 +- src/util/Makefile.inc.am | 4 + src/util/virarch.c | 3 +- src/util/viratomic.h | 351 +-------------- src/util/vircgroup.h | 2 +- src/util/vircrypto.c | 2 +- src/util/virenum.h | 8 +- src/util/virfdstream.c | 4 +- src/util/virfile.c | 18 +- src/util/virhostcpu.c | 3 +- src/util/virhostmem.c | 182 ++++++-- src/util/virinitctl.c | 4 +- src/util/virintprops.h | 526 ++++++++++++++++++++++ src/util/virkeycode.c | 22 +- src/util/virlog.c | 2 +- src/util/virmacaddr.h | 2 +- src/util/virnetdevbridge.c | 2 +- src/util/virobject.h | 8 +- src/util/virperf.c | 2 +- src/util/virpidfile.c | 2 +- src/util/virportallocator.c | 8 +- src/util/virprocess.c | 2 +- src/util/virsocket.c | 346 ++++++++++++++ src/util/virsocket.h | 89 ++++ src/util/virstoragefile.c | 4 +- src/util/virtime.c | 35 +- src/util/virtypedparam.h | 2 +- src/util/virutil.c | 4 +- src/vz/vz_driver.c | 2 +- tests/commandhelper.c | 3 + tests/commandtest.c | 3 + tests/qemuxml2argvmock.c | 12 +- tests/viratomictest.c | 2 +- tests/virstringtest.c | 7 +- tests/virsystemdtest.c | 2 +- tests/virtimetest.c | 39 +- tools/virsh-checkpoint.c | 20 +- tools/virsh-domain-monitor.c | 16 +- tools/virsh-domain.c | 15 +- tools/virsh-network.c | 13 +- tools/virsh-nodedev.c | 2 +- tools/virsh-pool.c | 2 +- tools/virsh-secret.c | 2 +- tools/virsh-snapshot.c | 19 +- tools/virsh.h | 1 - tools/virt-admin.c | 55 +-- tools/virt-host-validate-common.c | 4 +- tools/virt-login-shell.c | 7 +- tools/vsh.c | 16 +- tools/vsh.h | 4 +- 81 files changed, 1836 insertions(+), 733 deletions(-) create mode 100644 m4/virt-manywarnings.m4 create mode 100644 m4/virt-warnings.m4 create mode 100644 src/util/virintprops.h create mode 100644 src/util/virsocket.c create mode 100644 src/util/virsocket.h -- 2.24.1 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list