On 12/18/19 10:43 AM, Cole Robinson wrote:
> The phyp driver was added in 2009 and does not appear to have had any
> real feature change since 2011. There's virtually no evidence online
> of users actually using it. IMO it's time to kill it.
>
> Signed-off-by: Cole Robinson <crobinso@xxxxxxxxxx>
> ---
> I raised this in 3.5 years ago:
> https://www.redhat.com/archives/libvir-list/2016-April/msg01060.html
>
> Not much on phyp/ side has changed since then, except dozens of dev
> patches transitioning the code forward.
>
> That mail also mentions xenapi and hyperv. hyperv saw signs of life
> afterwards and is still around. xenapi has been removed, along with uml.
>
> Considering the amount of code transitions we are currently undergoing
> (gnulib, glib, memory auto cleanup, etc), phyp/ will probably have an
> uptick of dev energy in the medium term. Let's bite the bullet and
> remove it!
With this squashed in too, forgot about 'grep -i'
Maybe the auth.html.in bit can be entirely removed, I need to study how
that works
- Cole
diff --git a/configure.ac b/configure.ac
index 6c7c186d18..002a3dcdb0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -456,7 +456,6 @@ dnl
LIBVIRT_DRIVER_ARG_QEMU
LIBVIRT_DRIVER_ARG_OPENVZ
LIBVIRT_DRIVER_ARG_VMWARE
-LIBVIRT_DRIVER_ARG_PHYP
LIBVIRT_DRIVER_ARG_LIBXL
LIBVIRT_DRIVER_ARG_VBOX
LIBVIRT_DRIVER_ARG_LXC
@@ -473,7 +472,6 @@ LIBVIRT_DRIVER_ARG_INTERFACE
LIBVIRT_DRIVER_CHECK_QEMU
LIBVIRT_DRIVER_CHECK_OPENVZ
LIBVIRT_DRIVER_CHECK_VMWARE
-LIBVIRT_DRIVER_CHECK_PHYP
LIBVIRT_DRIVER_CHECK_LIBXL
LIBVIRT_DRIVER_CHECK_VBOX
LIBVIRT_DRIVER_CHECK_LXC
@@ -953,7 +951,6 @@ LIBVIRT_DRIVER_RESULT_VMWARE
LIBVIRT_DRIVER_RESULT_VBOX
LIBVIRT_DRIVER_RESULT_LIBXL
LIBVIRT_DRIVER_RESULT_LXC
-LIBVIRT_DRIVER_RESULT_PHYP
LIBVIRT_DRIVER_RESULT_ESX
LIBVIRT_DRIVER_RESULT_HYPERV
LIBVIRT_DRIVER_RESULT_VZ
diff --git a/docs/auth.html.in b/docs/auth.html.in
index 62af43a915..f198f39b64 100644
--- a/docs/auth.html.in
+++ b/docs/auth.html.in
@@ -129,7 +129,7 @@ credentials=defgrp</pre>
<li><code>libvirt</code> - used for connections to a libvirtd
server, which is configured with SASL auth</li>
<li><code>ssh</code> - used for connections to a Phyp server
- over SSH</li>
+ over SSH, but the Phyp driver has been removed</li>
<li><code>esx</code> - used for connections to an ESX or
VirtualCenter server</li>
</ol>
diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h
index 685e171235..3c65299840 100644
--- a/include/libvirt/virterror.h
+++ b/include/libvirt/virterror.h
@@ -84,7 +84,7 @@ typedef enum {
VIR_FROM_ONE = 27, /* The OpenNebula driver no longer exists.
Retained for ABI/API compat only */
VIR_FROM_ESX = 28, /* Error from ESX driver */
- VIR_FROM_PHYP = 29, /* Error from IBM power hypervisor */
+ VIR_FROM_PHYP = 29, /* Error from the (removed) phyp driver */
VIR_FROM_SECRET = 30, /* Error from secret storage */
VIR_FROM_CPU = 31, /* Error from CPU driver */
diff --git a/src/README b/src/README
index 0c4d3b58c7..7ddbc08bfe 100644
--- a/src/README
+++ b/src/README
@@ -40,7 +40,7 @@ Then there are the hypervisor implementations:
Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU and Xen drivers.
-The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
+The ESX, Hyper-V, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly
* cpu/ - CPU feature management
diff --git a/tools/virsh.c b/tools/virsh.c
index e70711f5d2..9fb9ed6430 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -522,9 +522,6 @@ virshShowVersion(vshControl *ctl G_GNUC_UNUSED)
#ifdef WITH_VMWARE
vshPrint(ctl, " VMware");
#endif
-#ifdef WITH_PHYP
- vshPrint(ctl, " PHYP");
-#endif
#ifdef WITH_VBOX
vshPrint(ctl, " VirtualBox");
#endif
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
