Thanks. I have sent a patch based off the tip here:
I also have a patch off libvirt-4.5 which I have tested on our HW. If needed, I can send that patch as well.
Ani
On Dec 2, 2019, 5:22 PM +0530, Daniel P. Berrangé <berrange@xxxxxxxxxx>, wrote:
On Wed, Nov 27, 2019 at 11:10:21AM +0000, Ani Sinha wrote:
Hi :
I see a commit in qemu that adds support for CLZERO but in CPUIDs. :
commit e900135dcfb676a4019dc206395e02db5d1de0d6
Author: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
Date: Wed Sep 25 23:49:48 2019 +0200
i386: Add CPUID bit for CLZERO and XSAVEERPTR
The CPUID bits CLZERO and XSAVEERPTR are availble on AMD's ZEN platform
and could be passed to the guest.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Is there a corresponding change in libvirt adding this capability? Libvirt complains when I add it manually in the vm xml:
# virsh create newvm.xml
error: Failed to create domain from newvm.xml
error: unsupported configuration: unknown CPU feature: clzero
# grep clzero newvm.xml
<feature policy='require' name='clzero'/>
Should we add it?
Yes, if it is supported by QEMU to expose to a guest, then it should be
added to libvirt too.
Presumably only needs add an addition to src/cpu_maps/x86_features.xml
Regards,
Daniel
--
|: https://urldefense.proofpoint.com/v2/url?u=https-3A__berrange.com&d=DwIFaQ&c=s883GpUCOChKOHiocYtGcg&r=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U&m=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI&s=HIAImXOwBBjDjbozqHZOBn1uaSs-AU3LugXqoQrrLko&e= -o- https://urldefense.proofpoint.com/v2/url?u=https-3A__www.flickr.com_photos_dberrange&d=DwIFaQ&c=s883GpUCOChKOHiocYtGcg&r=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U&m=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI&s=6zWQAT7zkr1fFfhCvnSAN6tLwYa1vFb0m66XYH46Vgw&e= :|
|: https://urldefense.proofpoint.com/v2/url?u=https-3A__libvirt.org&d=DwIFaQ&c=s883GpUCOChKOHiocYtGcg&r=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U&m=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI&s=mSj1Kh5NlO-NiBTedJkvXyreeEvNDLcEAkxVV8TxUmY&e= -o- https://urldefense.proofpoint.com/v2/url?u=https-3A__fstop138.berrange.com&d=DwIFaQ&c=s883GpUCOChKOHiocYtGcg&r=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U&m=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI&s=mw-XirgI1BWzbKo6zZTTY_SMrUw0aD1j6CiHYAhTVJw&e= :|
|: https://urldefense.proofpoint.com/v2/url?u=https-3A__entangle-2Dphoto.org&d=DwIFaQ&c=s883GpUCOChKOHiocYtGcg&r=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U&m=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI&s=gDp9hO9xGy4cPvntUrsFe_9iiycTQSeX7II4_RzQeA0&e= -o- https://urldefense.proofpoint.com/v2/url?u=https-3A__www.instagram.com_dberrange&d=DwIFaQ&c=s883GpUCOChKOHiocYtGcg&r=IIUxIyRwG4RGy57y2nvMNYcDkqW-NHozZ2R38VYcg5U&m=PLIQbn3uvPc_Hvp-uU09tByBWn_UFE0wrSWE2MeXnLI&s=_vzLCn26_4Iv36BEhb8Et71nUZIB6-m6JTa97ffbqMM&e= :|
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
