Re: [PATCH RFC 00/11] qemu: Introduce support for ARM CPU features

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2019-08-12 at 16:04 +0200, Michal Privoznik wrote:
> On 7/25/19 4:06 PM, Andrea Bolognani wrote:
> > Andrea Bolognani (11):
> >    tests: Update replies for QEMU 2.12.0 on aarch64
> >    tests: Add replies for QEMU 4.1.0 on aarch64
> >    qemu: Rename virQEMUCapsObjectPropsMaxX86CPU
> >    qemu: Introduce QEMU_CAPS_ARM_MAX_CPU
> >    qemu: Query max-arm-cpu properties
> >    qemu: Update query-cpu-model-expansion check
> >    qemu: Perform full expansion on ARM
> >    cpu_map: Introduce ARM CPU features
> >    cpu: Validate ARM CPU features
> >    tests: Introduce tests for ARM CPU features
> >    news: Update for ARM CPU features
> 
> Once qemu part is pushed in you can count on my
> 
> Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

So, the QEMU part ended up taking longer than expected and only
landed a few days ago, so it's going to show up in 4.2.0 instead of
the expected 4.1.0; additionally, through testing Drew and I have
found a few areas where the behavior could be improved.

As a result, [v1] is in some areas different enough from the version
you ACKed that it would not have been appropriate for me to just go
ahead and push it. (On the other hand, a bunch of commits are
basically unchanged and I could have included your R-b when posting,
my bad!)

Would you mind taking a look at the refreshed version? I have
included a reasonably detailed summary of the changes below: the
tl;dr is that only two of the eleven patches will require more than
a cursory look, so hopefully that's not too much bother.

Thanks in advance! :)


   new | old | changes
  ----- ----- -------------------------------------------------
     - |   1 | pushed
     1 |   2 | capabilities are for QEMU 4.2.0 instead of 4.1.0
     2 |   3 | trivial conversion to GLib APIs
     3 |   4 | -
     4 |   5 | trivial conversion to GLib APIs
     5 |   6 | -
     6 |   7 | -
     7 |   8 | added the 'sve' feature
     8 |   9 | significant changes due to GLib adoption
     9 |   - | entirely new patch
    10 |  10 | more testing, specifically for the 'sve' feature
    11 |  11 | -


[v1] https://www.redhat.com/archives/libvir-list/2019-November/msg00127.html
-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux