Re: [PATCH 03/16] docs: hacking: emphasize some sections

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 19, 2019 at 12:36:37AM +0200, Ján Tomko wrote:
> Namely:
> * holding up the first-time patch submissions for moderation,
>   which might cause first-time submitters to question the process
> * not CC-ing individual developers
> 
> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> ---
>  docs/hacking.html.in | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/docs/hacking.html.in b/docs/hacking.html.in
> index 42c8596abe..71a6ccc18b 100644
> --- a/docs/hacking.html.in
> +++ b/docs/hacking.html.in
> @@ -72,8 +72,8 @@
>  </pre>
>          <p>As a rule, patches should be sent to the mailing list only: all
>          developers are subscribed to libvir-list and read it regularly, so
> -        please don't CC individual developers unless they've explicitly
> -        asked you to.</p>
> +        <strong>please don't CC individual developers</strong> unless
> +        they've explicitly asked you to.</p>
>          <p>Avoid using mail clients for sending patches, as most of them
>          will mangle the messages in some way, making them unusable for our
>          purposes.  Gmail and other Web-based mail clients are particularly
> @@ -81,9 +81,10 @@
>          <p>If everything went well, your patch should show up on the
>          <a href="https://www.redhat.com/archives/libvir-list/";>libvir-list
>          archives</a> in a matter of minutes; if you still can't find it on
> -        there after an hour or so, you should double-check your setup.  Note
> -        that your very first post to the mailing list will be subject to
> -        moderation, and it's not uncommon for that to take around a day.</p>
> +        there after an hour or so, you should double-check your setup.
> +        <strong>Note that your very first post to the mailing list will be
> +        subject to moderation</strong>, and it's not uncommon for that to
> +        take around a day.</p>

s/Note that/Note that, if you are not already a subscriber,/

>          <p>Please follow this as close as you can, especially the rebase and
>          <code>git send-email</code> part, as it makes life easier for other
>          developers to review your patch set.</p>

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux