Our HACKING file is clear about requiring submission from a git
checkout, which automatically enables -Werror.
Remove the mentions of explicitly enabling it to alleviate
the collective cognitive encumbrance.
Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
---
docs/hacking.html.in | 18 ++----------------
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/docs/hacking.html.in b/docs/hacking.html.in
index 71a6ccc18b..d8f748626e 100644
--- a/docs/hacking.html.in
+++ b/docs/hacking.html.in
@@ -140,14 +140,7 @@
</li>
<li><p>Run the automated tests on your code before submitting any changes.
- In particular, configure with compile warnings set to
- -Werror. This is done automatically for a git checkout; from a
- tarball, use:</p>
-<pre>
- ./configure --enable-werror
-</pre>
- <p>
- and run the tests:
+ That is:
</p>
<pre>
make check
@@ -1473,14 +1466,7 @@ int foo()
how things work, it's better
to wait for a more authoritative feedback though. Before committing, please
also rebuild locally, run 'make check syntax-check', and make sure you
- don't raise errors. Try to look for warnings too; for example,
- configure with
- </p>
-<pre>
- --enable-compile-warnings=error
-</pre>
- <p>
- which adds -Werror to compile flags, so no warnings get missed
+ don't raise errors.
</p>
<p>
--
2.21.0
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
