On Thu, 2019-10-10 at 08:55 +0200, Erik Skultety wrote: > On Wed, Oct 09, 2019 at 02:01:37PM +0200, Peter Krempa wrote: > > On Wed, Oct 09, 2019 at 12:37:15 +0100, Daniel Berrange wrote: > > > Note that the check-spacing.py script is significantly > > > slower in Python than in Perl. After researching this > > > it appears there is nothing that can be done. The Perl > > > regex engine is simply much better optimized than the > > > Python one. As previously discussed we need to loook > > > at uncrustify or clang-format or some other tool to > > > validate whitespace formatting. This is ongoing. We > > > can either accept the slow down in the short term or > > > keep the Perl version in the short term. > > > > I vote for keeping the perl version then. I don't see much value in > > rewriting it into a much slower form just to drop it soon after. > > I second ^this opinion. Same, especially if it puts more pressure on us finally adopting something like clang-format. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
