Re: [PATCH v4 00/26] scripts: convert most perl scripts to python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 09, 2019 at 02:01:37PM +0200, Peter Krempa wrote:
> On Wed, Oct 09, 2019 at 12:37:15 +0100, Daniel Berrange wrote:
>
> [...]
>
> >  - src/rpc/gendispatch.pl
> >  - src/rpc/genprotocol.pl
> >  - tools/wireshark/util/genxdrstub.pl
>
> [...]
>
> > Note that the check-spacing.py script is significantly
> > slower in Python than in Perl. After researching this
> > it appears there is nothing that can be done. The Perl
> > regex engine is simply much better optimized than the
> > Python one.  As previously discussed we need to loook
> > at uncrustify or clang-format or some other tool to
> > validate whitespace formatting. This is ongoing. We
> > can either accept the slow down in the short term or
> > keep the Perl version in the short term.
>
> I vote for keeping the perl version then. I don't see much value in
> rewriting it into a much slower form just to drop it soon after.

I second ^this opinion.

Regards,
Erik

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux