On Tue, 2019-10-08 at 09:58 +0200, Fabiano Fidêncio wrote: > +++ b/guests/host_vars/libvirt-centos-7/main.yml > @@ -10,6 +10,7 @@ projects: > - libvirt-python > - osinfo-db > - osinfo-db-tools > + - virt-manager > - virt-viewer This hunk... > +++ b/guests/host_vars/libvirt-ubuntu-16/main.yml > @@ -13,6 +13,7 @@ projects: > - libvirt-tck > - osinfo-db > - osinfo-db-tools > + - virt-manager > - virt-viewer and this one are incorrect: we still can't build virt-manager on CentOS 7 and Ubuntu 16.04. Please drop them. > +++ b/guests/playbooks/build/projects/virt-manager.yml > @@ -5,6 +5,7 @@ > # virt-manager is Python 3 only, so it can't be built on CentOS 7; > # Ubuntu 16.04 has Python 3 but not the libxml2 bindings, so it can't > # build the project either > machines: > + - libvirt-debian-9 > - libvirt-debian-10 > - libvirt-debian-sid > - libvirt-fedora-29 The comment should be updated, as the motivation for not building virt-manager is the same for both CentOS 7 and Ubuntu 16.04 now. With these issues addressed, Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
