Re: [jenkins-ci PATCH v2 10/12] libvirt-dbus: Take advantage of Python 3 on CentOS 7

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2019-10-08 at 09:58 +0200, Fabiano Fidêncio wrote:
> +++ b/guests/playbooks/build/projects/libvirt-dbus.yml
> @@ -9,10 +9,10 @@
>  - include: '{{ playbook_base }}/jobs/autotools-build-job.yml'
>  - include: '{{ playbook_base }}/jobs/autotools-syntax-check-job.yml'
>    vars:
> -    # CentOS 7 doesn't include Python 3, while the versions of flake8
> -    # and pyflakes currently available on FreeBSD (3.5.0 and 2.0.0
> +    # flake8 and pyflakes versions available on FreeBSD (3.5.0 and 2.0.0
>      # respectively) are not compatible

This comment...

> +++ b/jenkins/projects/libvirt-dbus.yaml
> @@ -10,10 +10,10 @@
>            parent_jobs: 'libvirt-glib-build'
>        - autotools-syntax-check-job:
>            parent_jobs: 'libvirt-dbus-build'
> -          # CentOS 7 doesn't include Python 3, while the versions of flake8
> -          # and pyflakes currently available on FreeBSD (3.5.0 and 2.0.0
> -          # respectively) are not compatible
> +          # flake8 and pyflakes versions currently available on FreeBSD
> +          # (3.5.0 and 2.0.0 respectively) are not compatible.

... and this one don't match. Make sure they do.

With that fixed,

  Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux