On 4/7/19 1:32 AM, Michal Prívozník wrote: > On 4/7/19 6:16 AM, Roman Bogorodskiy wrote: >> Eric Blake wrote: >> >>> Had this been in place earlier, I would have avoided the bugs in >>> commit 0baf6945 and 55c2ab3e. Writing the test required me to extend >>> the power of virsh - creating enough snapshots to cause fanout >>> requires enough input in a single session that adding comments and >>> markers makes it easier to check that output is correct. It's still a >>> bit odd that with test:///default, reverting to a snapshot changes the >>> domain from running to paused (possibly a bug in how the test driver >>> copied from the qemu driver) - but the important part is that the test >>> is reproducible, and any future tweaks we make to snapshot code have >>> less chance of breaking successful command sequences. >>> >>> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> >>> --- >>> tests/Makefile.am | 3 +- >>> tests/virsh-snapshot | 212 +++++++++++++++++++++++++++++++++++++++++++ >>> 2 files changed, 214 insertions(+), 1 deletion(-) >>> create mode 100755 tests/virsh-snapshot >> >> Hi, >> >> I noticed this test is failing for me: > > > Shoot, running under valgrind shows the same problem: > > > Looks like the problem is that while iterating over list we remove some elements and then call (some different) iterator over them. Eric? Looks like I have a use-after-free to debug; will get a patch out as soon as I can come up with the right fix. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
