Given that my recent snapshot changes introduced two separate bugs, both of which were fairly easy to reproduce with the test:///default driver, but neither of which caused 'make check' to alert me to the problems, it's high time I submit a test, including enhancing virsh to give me the functionality the test needs. Eric Blake (5): snapshot: Avoid infloop during REDEFINE virsh: Parse # comments in batch mode virsh: Treat any command name starting with # as comment virsh: Add 'echo --err' option snapshot: Add tests of virsh -c test:///default snapshot* src/conf/snapshot_conf.c | 1 + tests/Makefile.am | 3 +- tests/virsh-snapshot | 212 +++++++++++++++++++++++++++++++++++++++ tests/virshtest.c | 7 ++ tools/virsh.pod | 10 +- tools/virt-admin.pod | 7 +- tools/vsh.c | 34 ++++++- 7 files changed, 263 insertions(+), 11 deletions(-) create mode 100755 tests/virsh-snapshot -- 2.20.1 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list