On 3/23/19 8:41 PM, Suyang Chen wrote: > Since commit 2e6ecba1bcac, the pointer to the qemu driver is saved in > domain object's private data and hence does not have to be passed as > yet another parameter if domain object is already one of them. > > This just changed qemuDomainChangeDiskLive and > qemuDomainChangeEjectableMedia functions > > Signed-off-by: Suyang Chen <dawson0xff@xxxxxxxxx> Thanks for the patch. Unfortunately a similar change prompted a discussion over here: https://www.redhat.com/archives/libvir-list/2019-March/msg01639.html And not everyone is in agreement that these types of changes, in isolation, are useful. So I don't think this patch will be applied. I will remove the associated bitesizedtask entry from the wiki so this doesn't cause additional confusion Thanks, Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
