[PATCH 1/5] snapshot: Avoid infloop during REDEFINE

[Eric Blake <eblake@xxxxxxxxxx>]

Commit 55c2ab3e accidentally introduced an infinite loop while
checking whether a redefined snapshot would cause an infinite loop in
chasing its parents back to a root.  Alas, 'make check' did not catch
it, so my next patch will be a testsuite improvement that would have
hung and prevented the bug from being checked in to begin with.

Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
---
 src/conf/snapshot_conf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c
index 52abafab0f..cc3f71ab6f 100644
--- a/src/conf/snapshot_conf.c
+++ b/src/conf/snapshot_conf.c
@@ -962,6 +962,7 @@ virDomainSnapshotRedefinePrep(virDomainPtr domain,
                          vm->def->name);
                 break;
             }
+            otherdef = virDomainSnapshotObjGetDef(other);
         }
     }

-- 
2.20.1

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list