On 3/15/19 12:02 AM, Eric Blake wrote: > This is a respin of patch 4/20 in my larger series: > https://www.redhat.com/archives/libvir-list/2019-March/msg00386.html > > As John pointed out, my v4/v5 posting had a LOT of duplicate code, > including lots of poorly commented code managing a potential tree of > checkpoints (even if the more immediate use tends to be a linear chain > than a full-blown tree), all because I had copied-and-pasted from > snapshot code. Copy-and-paste is technical debt; better is to get rid > of the debt by refactoring the code for easy reuse. 1-6 (including 1.5) had sufficient reviews; I'm pushing 1-5 now, and saving 6 until I can figure out if I can build src/vz (I'm trying to locate the parallels-sdk required by m4/virt-driver-vz.m4, either pre-built for Fedora, or that I can build myself). 7-8 will be respun, along with my next round of cleaned up patches, to appear later today (I hope). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
