Re: [PATCH v6 0/8] Incremental backups: virDomainSnapshot class

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/15/19 8:30 AM, Daniel P. Berrangé wrote:
> On Fri, Mar 15, 2019 at 08:24:35AM -0500, Eric Blake wrote:
>>> 0.69 prohibit_author
>>> prohibit_backslash_alignment
>>> src/datatypes.h:302:            !virObjectIsClass(virChkDom(_check), virDomainClass) ||     \
>>> src/datatypes.h:313:# define virCheckDomainSnapshotReturn(obj, retval)      \
>>> maint.mk: Do not attempt to right-align backslashes
>>> make: *** [sc_prohibit_backslash_alignment] Error 1
>>
>> Libvirt reviewers: Copied from pre-existing style, but I guess it means
>> I should clean up the formatting while touching this.
> 
> I'd think pre-existing code is already correct otherwise syntax-check
> would be broken in git master. Perhaps this is a check we introduced
> after you copied the existing code when starting your work.

Yep, that turns out to be the case.  (The penalty for taking 6 months to
polish this into something worth committing...)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux