On Wed, Mar 13, 2019 at 10:29:52 +0100, Andrea Bolognani wrote: > On Wed, 2019-03-13 at 10:12 +0100, Peter Krempa wrote: > > Actually I don't see the reason for anything in this patch. Each > > function is called exactly once, so splitting it out does not make much > > sense without any further justification. > > > > The need to reset data->ret to 0 is not enough of a justification. > > Better code organization: instead of having a bunch of initialization > and cleanup steps sprinkled throughout main(), we give them their own > functions and keep main() simple, clean and focused. Since I've ACK'd passing in of the data directory via the structure, this makes sense. Just get rid of the unused function.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
