On Wed, Mar 13, 2019 at 10:09:17 +0100, Andrea Bolognani wrote:
> On Wed, 2019-03-13 at 09:44 +0100, Peter Krempa wrote:
> > On Thu, Mar 07, 2019 at 16:44:30 +0100, Andrea Bolognani wrote:
> > > These functions don't do anything too interesting right now,
> > > but will be extended significantly later on.
> >
> > The state after all patches applied does not really look "significant"
>
> Fair enough, I'll drop the inaccurate adjective :)
>
> [...]
> > > +static void
> > > +testQemuDataReset(testQemuDataPtr data ATTRIBUTE_UNUSED)
> > > +{
> > > +}
> >
> > This function is never touched again in this series.
>
> Yeah, there's no memory that needs to be released for this specific
> structure. I can drop the function if you feel strongly about that,
> but I'd rather keep it for consistency with the other test program.
Actually I don't see the reason for anything in this patch. Each
function is called exactly once, so splitting it out does not make much
sense without any further justification.
The need to reset data->ret to 0 is not enough of a justification.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
