On 11/12/2018 02:50 PM, John Ferlan wrote: > v1: https://www.redhat.com/archives/libvir-list/2018-November/msg00339.html > > Changes since v1: > > * Do the right thing, revert the bad patch and rework it. Thus patch1 is > the revert and patch2 is the rework. If it's decided that patch2 is > unnecessary or undesired, that's perfectly fine, but would then require > a slight modification to the documentation from commit 4f1107614 to > remove the reference about the access denied message. > > * From review - add the virObjectUnref for the data->identity for which > a virIdentityGetCurrent reference was obtained. > > v1 cover: > > Patch 1 fixes my own error made in this release fortunately, but > only seen because I was invesigating Patch 2 > > Patch 2 is perhaps a longer term issue, but perhaps coming more to > light now that the nwfilter bindings have been separated and use > a virConnectOpen for nwfilter:///system during reconnection processing; > whereas, previously the filter bindings would have been "hidden" within > various nwfilter, domain, and network driver callbacks and throughs. > > John Ferlan (3): > Revert "access: Modify the VIR_ERR_ACCESS_DENIED to include > driverName" > access: Modify the VIR_ERR_ACCESS_DENIED to include driverName > qemu: Set identity for the reconnect all thread > > src/access/viraccessmanager.c | 3 ++- > src/qemu/qemu_process.c | 7 +++++++ > src/rpc/gendispatch.pl | 3 ++- > src/util/virerror.c | 4 ++-- > 4 files changed, 13 insertions(+), 4 deletions(-) > ACK Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
