Re: [PATCHv2] libvirt: add daemon itself as shutdown reason

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 14, 2018 at 05:19:35PM +0100, Andrea Bolognani wrote:
> On Tue, 2018-11-13 at 15:36 -0500, John Ferlan wrote:
> > From: Nikolay Shirokovskiy <nshirokovskiy@xxxxxxxxxxxxx>
> > 
> > This patch introduces a new shutdown reason "daemon" in order
> > to indicate that the daemon needed to force shutdown the domain
> > as the best course of action to take at the moment.
> > 
> > This action would occur during reconnection when processing
> > encounters an error once the monitor reconnection is successful.
> > 
> > Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@xxxxxxxxxxxxx>
> > Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>
> 
> This made language bindings sad:
> 
>   https://ci.centos.org/view/libvirt/job/libvirt-go-check/106/
>   https://ci.centos.org/view/libvirt/job/libvirt-perl-check/107/

This is normal - the check jobs are explicitly intended to fail
whenever public API additions are made to remind us (me) to add
support there.

> Interestingly, Python doesn't seem to be bothered at all.

python auto-generates some of its code.

> Anyway, it would be great if someone would add support for the new
> enum value to Go and Perl bindings and make CI happy again :)

I'm doing it..

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux