Re: [PATCH v3 2/5] libxl: add support for PVH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 02, 2018 at 06:54:01PM -0600, Jim Fehlig wrote:
> On 10/2/18 5:02 PM, Marek Marczykowski-Górecki wrote:
> > On Tue, Oct 02, 2018 at 04:50:02PM -0600, Jim Fehlig wrote:
> > > My idea to add this variable for clarity now seems diluted by the need for
> > > the extra ifdef's :-/. Your original approach would avoid them.
> > 
> > This #ifdef is only to mute compiler warning (variable set but unused).
> > If you have a better idea for that, I'd very much like to drop #ifdef
> > here.
> 
> Given the ifdef trickery needed with the extra variable, I think the better
> idea is your original idea :-)
> 
> i == nr_guest_archs - 1

Ok, will rollback to that. But I'll wait for os.machine/os.type opinion.

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux