On Mon, Sep 3, 2018 at 5:26 PM, Andrea Bolognani <abologna@xxxxxxxxxx> wrote:
> Please include a cover letter when sending more than a single
> patch to libvir-list.
>
> On Mon, 2018-09-03 at 15:02 +0200, Fabiano Fidêncio wrote:
> [...]
>> - include: '{{ playbook_base }}/jobs/autotools-check-job.yml'
>> + vars:
>> + local_env: |
>> + # export LIBOSINFO_NETWORK_TESTS in order to run both
>> + # mediauris and treeuris tests
>> + export LIBOSINFO_NETWORK_TESTS=1
>
> The above should be indented by two fewer spaces :)
>
> The comment also doesn't need to repeat the variable name or
> contain that much information really:
>
> Run tests that require network connectivity
>
> or something like that would be enough.
Right, I'll fix this and submit a v2.
>
>
> Anyway, the new tests seem to be failing on all platforms at the
> moment. Do you want to address the issue before changing the CI
> environment, or would seeing the CI failures help you in fixing
> it and should thus go in first?
I do want to address the issues before changing the CI and then the
patchset could be merged.
The main problem now is that Fedora ISO's for f27 were removed from
the standard location but still not added to the archives.
I'll re-send the patchset fixing your comments and also send an
osinfo-db patch as soon as the ISOs are added to the archive and only
then we can have the v2 merged.
>
> --
> Andrea Bolognani / Red Hat / Virtualization
>
Thanks for the review, Andrea!
Best Regards,
--
Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
