Please include a cover letter when sending more than a single
patch to libvir-list.
On Mon, 2018-09-03 at 15:02 +0200, Fabiano Fidêncio wrote:
[...]
> - include: '{{ playbook_base }}/jobs/autotools-check-job.yml'
> + vars:
> + local_env: |
> + # export LIBOSINFO_NETWORK_TESTS in order to run both
> + # mediauris and treeuris tests
> + export LIBOSINFO_NETWORK_TESTS=1
The above should be indented by two fewer spaces :)
The comment also doesn't need to repeat the variable name or
contain that much information really:
Run tests that require network connectivity
or something like that would be enough.
Anyway, the new tests seem to be failing on all platforms at the
moment. Do you want to address the issue before changing the CI
environment, or would seeing the CI failures help you in fixing
it and should thus go in first?
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
