Re: [PATCH v3 10/20] nwfilter: convert the gentech driver code to use virNWFilterBindingDefPtr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 06/14/2018 08:32 AM, Daniel P. Berrangé wrote:
> Use the virNWFilterBindingDefPtr struct in the gentech driver code
> directly.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  src/nwfilter/nwfilter_dhcpsnoop.c      |  39 ++--
>  src/nwfilter/nwfilter_driver.c         |  24 ++-
>  src/nwfilter/nwfilter_gentech_driver.c | 236 ++++++++++++-------------
>  src/nwfilter/nwfilter_gentech_driver.h |  22 ++-
>  src/nwfilter/nwfilter_learnipaddr.c    |  18 +-
>  5 files changed, 175 insertions(+), 164 deletions(-)
> 

FWIW: existing, but virNWFilterDoInstantiate doesn't have a complete
list of parameters in the method doc... Missing ifindex, useNewFilter,
foundNewFilter, teardownOld, and driver.


Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux