On 06/14/2018 08:32 AM, Daniel P. Berrangé wrote: > $ virsh nwfilter-binding-list > Port Dev Filter > ------------------------------------------------------------------ > vnet0 clean-traffic > vnet1 clean-traffic > > $ virsh nwfilter-binding-dumpxml vnet1 > <filterbinding> > <owner> > <name>f25arm7</name> > <uuid>12ac8b8c-4f23-4248-ae42-fdcd50c400fd</uuid> > </owner> > <portdev name='vnet1'/> > <mac address='52:54:00:9d:81:b1'/> > <filterref filter='clean-traffic'> > <parameter name='MAC' value='52:54:00:9d:81:b1'/> > </filterref> > </filterbinding> > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > --- > tools/virsh-completer.c | 45 ++++++ > tools/virsh-completer.h | 4 + > tools/virsh-nwfilter.c | 317 ++++++++++++++++++++++++++++++++++++++++ > tools/virsh-nwfilter.h | 8 + > 4 files changed, 374 insertions(+) > Will need virsh.pod changes to describe the new commands. I'm OK if you just post an update as a reply. The rest looked fine - although a few more usage comments in the new API's may be nice. John Would probably be a very interesting Avocado test to write - something that continue creates/deletes the binding while perhaps the guest is doing the start/destroy loop -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
