On Tue, Jun 12, 2018 at 11:07:51AM +0100, Daniel P. Berrangé wrote: > On Mon, Jun 11, 2018 at 11:17:02AM -0500, Brijesh Singh wrote: > > Hi Erik, > > > > > > On 06/11/2018 09:10 AM, Erik Skultety wrote: > > > On Fri, Jun 08, 2018 at 10:14:35AM -0500, Brijesh Singh wrote: > > > > > > > > Re: Jano's below comment > > > > > > > > (Also, some of the patches have double "<< >>" around your e-mail, > > > > how did that happen?) > > > > > > > > I am not sure what I am doing that is causing the double "<< >>" around my > > > > email address in some patches. I tried fixing it after I saw Jano note but > > > > it somehow happens again...I have no explanation on what is going on. > > > > Whoever commits the series, can you please remove one of the quote from the > > > > my email address, Or I can try fixing it and resend the series. Please let > > > > me know. thanks > > > > > > For the whole series (I'll make the tiny change in patch 5): > > > Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx> > > > > > > I'll also tweak the double angle brackets, at first I thought you were adding > > > the SoB manually and this was a typo, but it clearly isn't the case, it would > > > be pointless to bikeshed about that, so as I said, I'll take care of that > > > before merging. > > > > > > Also, now that this is done, would take also take care of extending the other > > > language bindings for the new APIs, or shall I do that? > > > > > > Thanks for all your help in reviews. Any help on language bindings for the > > new APIs are appreciated. I think I may able to do python but will certainly > > need help with others (I am not very familiar with other languages). > > Thanks for all your hard work in developing this feature for libvirt and > patience with the many rounds of the review process. > > I will take care of the Go & Perl bindings if no one beats me to it. I'm working on the python ones at the moment, thanks Daniel for taking care of Go & Perl. Erik -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
