On Thu, Jun 07, 2018 at 21:18:30 -0400, John Ferlan wrote: > > > On 06/04/2018 09:58 AM, Peter Krempa wrote: > > On EOF, the loop can be terminated right away since most of it is > > skipped anyways and the handling of the last command is repeated after > > the loop. > > > > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> > > --- > > tests/qemumonitortestutils.c | 24 +++++++++++------------- > > 1 file changed, 11 insertions(+), 13 deletions(-) > > > > Would this be more readable with virStringSplit[Count] ? Every time I > see strchr, that's where I go... > > What's here is fine, but figured I'd ask anyway. It's not really possible here as the code is removing newlines from the code until it hits an empty line. We could use virStringSplitCount to pick the full reply, but AFAIK we'd still need to remove the single newlines so that the monitor code does not get confused. > > Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> > > John >
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
