Re: [PATCH 03/10] tests: qemumonitor: Simplify handling of end of file in full file test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 06/04/2018 09:58 AM, Peter Krempa wrote:
> On EOF, the loop can be terminated right away since most of it is
> skipped anyways and the handling of the last command is repeated after
> the loop.
> 
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  tests/qemumonitortestutils.c | 24 +++++++++++-------------
>  1 file changed, 11 insertions(+), 13 deletions(-)
> 

Would this be more readable with virStringSplit[Count] ?  Every time I
see strchr, that's where I go...

What's here is fine, but figured I'd ask anyway.

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux