On Thu, 2018-06-07 at 09:52 +0200, Martin Kletzander wrote: > On Wed, Jun 06, 2018 at 11:28:27AM +0100, Daniel P. Berrangé wrote: > > On Wed, Jun 06, 2018 at 11:27:38AM +0200, Andrea Bolognani wrote: > > > On Tue, 2018-06-05 at 18:47 +0100, Daniel P. Berrangé wrote: > > > > The container images provided by Travis only support Ubuntu 14.04, > > > > however, Travis has ability to run docker, which allows the build > > > > script to use arbitrary OS images. This takes advantage of that to > > > > convert the build over to Ubuntu 16.04 and 18.04 > > > > > > Neat! I was not aware that was possible. TIL :) > > > > Yeah, nor was I until yesterday when I found someone saying this is > > the way to get off the ancient Ubuntu versions in Travis :-) > > Oh, maybe you just forgot, we had some improvement suggestions like a year ago > but we missed some e-mails, I guess. Sometimes stuff slips through the cracks ¯\_(ツ)_/¯ If you feel like fishing that out and checking whether any of the suggested improvements would still apply, that would be great; that said, outside of the minor issues pointed out during review, Dan's approach looks pretty solid to me. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
