On Wed, 2018-05-16 at 15:56 +0200, Andrea Bolognani wrote: > On Wed, 2018-05-16 at 13:39 +0100, Daniel P. Berrangé wrote: > > On Tue, May 15, 2018 at 08:27:35PM +0200, Andrea Bolognani wrote: > > > Module::Build requires Archive::Tar in order to create > > > distribution archives, but on some operating systems there > > > is no explicit dependency dragging it the latter when > > > installing the former, so we need to handle it ourselves. > > > > Hmm, any idea why we didn't see a failure already with libvirt-tck > > then ? > > I thought it was because we were not building libvirt-tck on the > machines where libvirt-perl RPM build was failing, but it looks > like that's not the case, so it might have been a red herring. > > I'll take another look. Okay, the thing is that on Fedora Module::Build drags in Archive::Tar but on CentOS it doesn't; the reason we didn't see any breakages is that we don't build libvirt-tck on CentOS. tl;dr this patch is needed; the other one (Package::Constants) can be safely skipped. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list