Re: [jenkins-ci PATCH 2/3] guests: Add Archive::Tar dependency for Perl projects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 15, 2018 at 08:27:35PM +0200, Andrea Bolognani wrote:
> Module::Build requires Archive::Tar in order to create
> distribution archives, but on some operating systems there
> is no explicit dependency dragging it the latter when
> installing the former, so we need to handle it ourselves.

Hmm, any idea why we didn't see a failure already with libvirt-tck
then ?

> 
> Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
> ---
>  guests/vars/mappings.yml              | 5 +++++
>  guests/vars/projects/libvirt-perl.yml | 1 +
>  guests/vars/projects/libvirt-tck.yml  | 1 +
>  3 files changed, 7 insertions(+)
> 
> diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
> index cfba51c..f809e24 100644
> --- a/guests/vars/mappings.yml
> +++ b/guests/vars/mappings.yml
> @@ -514,6 +514,11 @@ mappings:
>      default: perl
>      FreeBSD: perl5
>  
> +  perl-Archive-Tar:
> +    deb: perl
> +    pkg: perl5
> +    rpm: perl-Archive-Tar
> +
>    perl-CPAN-Changes:
>      deb: libcpan-changes-perl
>      pkg: p5-CPAN-Changes
> diff --git a/guests/vars/projects/libvirt-perl.yml b/guests/vars/projects/libvirt-perl.yml
> index a19e232..2eb14f2 100644
> --- a/guests/vars/projects/libvirt-perl.yml
> +++ b/guests/vars/projects/libvirt-perl.yml
> @@ -1,5 +1,6 @@
>  ---
>  packages:
> +  - perl-Archive-Tar
>    - perl-CPAN-Changes
>    - perl-Module-Build
>    - perl-Test-Pod
> diff --git a/guests/vars/projects/libvirt-tck.yml b/guests/vars/projects/libvirt-tck.yml
> index 8d29c1c..dcccc0f 100644
> --- a/guests/vars/projects/libvirt-tck.yml
> +++ b/guests/vars/projects/libvirt-tck.yml
> @@ -1,5 +1,6 @@
>  ---
>  packages:
> +  - perl-Archive-Tar
>    - perl-Config-Record
>    - perl-Digest
>    - perl-Digest-MD5

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux