Am 19.04.2018 um 17:25 hat Peter Krempa geschrieben: > Similarly to the 'raw' case add tests for bochs, cloop, dmg, ploop, vdi > vhd, and vpc. Covering all supproted non-backing formats. > > Note that the JSON name for 'ploop' maps to 'parallels' and 'vhd' maps > to 'vhdx'. Your -drive lines below mention format=ploop/vhd, though. That wouldn't actually work. (Also 'vhd' as an alias for 'vhdx' is super confusing, because VHD is really the name of the format implemented by QEMU's 'vpc' driver - which is already a source of confusion on its own.) > Files added here would result in the followint configs: > > file-bochs-noopts.xml: > -drive file=/path/to/i.img,format=bochs,if=none,id=drive-dummy > -device virtio-blk-pci,scsi=off,drive=drive-dummy,id=dummy > > file-cloop-noopts.xml: > -drive file=/path/to/i.img,format=cloop,if=none,id=drive-dummy > -device virtio-blk-pci,scsi=off,drive=drive-dummy,id=dummy > > file-dmg-noopts.xml: > -drive file=/path/to/i.img,format=dmg,if=none,id=drive-dummy > -device virtio-blk-pci,scsi=off,drive=drive-dummy,id=dummy > > file-ploop-noopts.xml: > -drive file=/path/to/i.img,format=ploop,if=none,id=drive-dummy > -device virtio-blk-pci,scsi=off,drive=drive-dummy,id=dummy > > file-vdi-noopts.xml: > -drive file=/path/to/i.img,format=vdi,if=none,id=drive-dummy > -device virtio-blk-pci,scsi=off,drive=drive-dummy,id=dummy > > file-vhd-noopts.xml: > -drive file=/path/to/i.img,format=vhd,if=none,id=drive-dummy > -device virtio-blk-pci,scsi=off,drive=drive-dummy,id=dummy > > file-vpc-noopts.xml: > -drive file=/path/to/i.img,format=vpc,if=none,id=drive-dummy > -device virtio-blk-pci,scsi=off,drive=drive-dummy,id=dummy > > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> Some of the cases tested here or in later patches are for configurations that wouldn't work, but I guess for a test of parsing and storing XML, that doesn't matter. Kevin -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
