Re: [dbus PATCH 5/8] Implement GetAllDomainStats method for Connect Interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-04-19 at 16:45 +0200, Ján Tomko wrote:
> On Thu, Apr 19, 2018 at 03:58:04PM +0200, Katerina Koukiou wrote:
> > Signed-off-by: Katerina Koukiou <kkoukiou@xxxxxxxxxx>
> > ---
> > data/org.libvirt.Connect.xml |  7 +++++++
> > src/connect.c                | 40
> > ++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 47 insertions(+)
> > 
> > diff --git a/data/org.libvirt.Connect.xml
> > b/data/org.libvirt.Connect.xml
> > index e5504f7..3ef965d 100644
> > --- a/data/org.libvirt.Connect.xml
> > +++ b/data/org.libvirt.Connect.xml
> > @@ -94,6 +94,13 @@
> >       <arg name="flags" type="u" direction="in"/>
> >       <arg name="storagePoolSources" type="s" direction="out"/>
> >     </method>
> > +    <method name="GetAllDomainStats">
> > +      <annotation name="org.gtk.GDBus.DocString"
> > +        value="See https://libvirt.org/html/libvirt-libvirt-host.h
> > tml#virConnectGetAllDomainStats"/>;
> 
> This one is documented in https://libvirt.org/html/libvirt-libvirt-do
> main.html#virConnectGetAllDomainStats
> 
> Given that our API names are set in stone but our website URLs are
> not,
> maybe we need some stable link that would redirect to the correct doc
> page when given an API name.
> 

Yes, good point. The docs need to be enhanced in general anyway.

> Jano
> 
> > +      <arg name="stats" type="u" direction="in"/>
> > +      <arg name="flags" type="u" direction="in"/>
> > +      <arg name="records" type="av" direction="out"/>
> > +    </method>
> >     <method name="GetCapabilities">
> >       <annotation name="org.gtk.GDBus.DocString"
> >         value="See https://libvirt.org/html/libvirt-libvirt-host.ht
> > ml#virConnectGetCapabilities"/>;

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux