Re: [dbus PATCH 5/8] Implement GetAllDomainStats method for Connect Interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 19, 2018 at 03:58:04PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou <kkoukiou@xxxxxxxxxx>
> ---
>  data/org.libvirt.Connect.xml |  7 +++++++
>  src/connect.c                | 40 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 47 insertions(+)
> 
> diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
> index e5504f7..3ef965d 100644
> --- a/data/org.libvirt.Connect.xml
> +++ b/data/org.libvirt.Connect.xml
> @@ -94,6 +94,13 @@
>        <arg name="flags" type="u" direction="in"/>
>        <arg name="storagePoolSources" type="s" direction="out"/>
>      </method>
> +    <method name="GetAllDomainStats">
> +      <annotation name="org.gtk.GDBus.DocString"
> +        value="See https://libvirt.org/html/libvirt-libvirt-host.html#virConnectGetAllDomainStats"/>
> +      <arg name="stats" type="u" direction="in"/>
> +      <arg name="flags" type="u" direction="in"/>
> +      <arg name="records" type="av" direction="out"/>

The return type should be "a(sa{sv})" because it returns stats for
multiple domains.  For example:

[
    ( "centos6", { "state.state": 1, "state.reason": 1 } ),
    ( "centos7", { "state.state": 5, "state.reason": 1 } )
]

and the code needs to be updated accordingly.

Pavel

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux