On Tue, Apr 17, 2018 at 02:52:08PM +0200, Andrea Bolognani wrote:
> On Tue, 2018-04-17 at 13:08 +0100, Daniel P. Berrangé wrote:
> > Hmm, this is a problem with us repurposing 'name' as a parameter
> > for the template, when it is also a declared field.
> >
> > eg the core issue is this:
> >
> > name: '{name}-{branch}-build'
> >
> > We should address this by changing the parameter name to be
> > 'projname', so it doesn't clash with the official 'name'
> > field used as the job name.
>
> Are you sure? It seems to me like the problem stems from the fact
> that we have both
>
> - job-template:
> id: autotools-build-job
> name: '{name}-{branch}-build'
>
> and
>
> - job-template:
> id: generic-build-job
> name: '{name}-{branch}-build'
>
> Even if we had a separate 'projname' parameter, the names of the
> generated jobs would end up being the same.
I meant that if we had 'projname' parameter, then we have the
ability to override the job name using:
'name: libvirt-master-website'
without affecting all the expansion of all the other bits of the
template, as they now get driven by {projname} instead.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
