Re: [jenkins-ci PATCH v2 3/6] projects: Add libvirt-master-website job

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2018-04-17 at 13:08 +0100, Daniel P. Berrangé wrote:
> Hmm, this is a problem with us repurposing 'name' as a parameter
> for the template, when it is also a declared field.
> 
> eg the core issue is this:
> 
>     name: '{name}-{branch}-build'
> 
> We should address this by changing the parameter name to be
> 'projname', so it doesn't clash with the official 'name'
> field used as the job name.

Are you sure? It seems to me like the problem stems from the fact
that we have both

  - job-template:
      id: autotools-build-job
      name: '{name}-{branch}-build'

and

  - job-template:
      id: generic-build-job
      name: '{name}-{branch}-build'

Even if we had a separate 'projname' parameter, the names of the
generated jobs would end up being the same.

I guess we could come up with a

  - job-template:
      id: generic-command-job
      name: '{name}-{branch}-{unique}'

but that template would need to include the scm: configuration and
everything else...

Basically, it would end up looking pretty much exactly like like
generic-build-job or the autotools-website-job I proposed. Having
a more generic version of that would be a net win if we had a
bunch of these oddball jobs, but with a single one (which we will
hopefully be able to drop at some point in the not-too-distant
future!) on the table we might as well not bother.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux