Re: [libvirt PATCH v2 01/44] qemuxml2argvtest: Fix q35-virt-manager capabilities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-04-05 at 14:22 +0200, Ján Tomko wrote:
> Use QEMU_CAPS_MACHINE_OPT and QEMU_CAPS_MACHINE_VMPORT_OPT
> since it specifies <vmport state=off/>.
> 
> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> ---
>  tests/qemuxml2argvdata/q35-virt-manager-basic.args | 2 +-
>  tests/qemuxml2argvtest.c                           | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)

Kinda weird that we don't just error out if vmport is configured
and we clearly have no way of enforcing it.

Regardless,

  Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux