On Thu, Mar 29, 2018 at 01:51:04PM +0200, Peter Krempa wrote:
This is a storage driver type, which is not handled in qemu driver
properly. For accessing directories, disk type 'dir' is used instead.
Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
src/qemu/qemu_domain.c | 7 +++++++
tests/qemuxml2argvdata/disk-drive-fmt-dir.xml | 27 +++++++++++++++++++++++++++
tests/qemuxml2argvtest.c | 1 +
3 files changed, 35 insertions(+)
create mode 100644 tests/qemuxml2argvdata/disk-drive-fmt-dir.xml
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 960a78f082..88b4653da5 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -4117,6 +4117,13 @@ qemuDomainValidateStorageSource(virStorageSourcePtr src)
return -1;
}
+ if (src->format == VIR_STORAGE_FILE_DIR) {
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+ _("'directory' storage format is not directly suppored by qemu, "
+ "use 'dir' disk type instead"));
No idea how to emojify that. ACK Jano
+ return -1;
+ }
+
return 0;
}
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
