Re: [PATCH 06/14] qemu: domain: Forbid storage type 'cow' in qemu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 29, 2018 at 01:51:03PM +0200, Peter Krempa wrote:
QEMU does not support it so save us hassle and forbid it right away.

*the hassle


Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
src/qemu/qemu_domain.c                        | 23 +++++++++++++++++++++++
tests/qemuxml2argvdata/disk-drive-fmt-cow.xml | 27 +++++++++++++++++++++++++++
tests/qemuxml2argvtest.c                      |  1 +
3 files changed, 51 insertions(+)
create mode 100644 tests/qemuxml2argvdata/disk-drive-fmt-cow.xml

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 009fb9daf3..960a78f082 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -4108,9 +4108,24 @@ qemuDomainDeviceDefValidateVideo(const virDomainVideoDef *video)
}


+static int
+qemuDomainValidateStorageSource(virStorageSourcePtr src)
+{
+    if (src->format == VIR_STORAGE_FILE_COW) {
+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                      _("'cow' storage format is not supported"));

You could also say '🐄'.

+        return -1;
+    }
+
+    return 0;
+}
+
+

ACK regardless

Jano

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux